Possible version 8 permissions/cache issue

triplei · June 21, 2023, 10:02pm

I’m working on a site which originated as a version 7 installation and is currently running 8.5.12. As a super admin I can create page drafts. A regular site administrator gets a 500 error with a stack trace pasted below.

It appears to be related to loading permissions from the request cache. Reverting this commit: Avoid to cache permission access list items for drafts · concretecms/concretecms@244542b · GitHub appears to fix the issue (or bypassing the cache by passing in false on line 124 of Access.php - concretecms/concrete/src/Permission/Access/Access.php at 34cd69a6d8dc1d6d936396b39412667546928b1c · concretecms/concretecms · GitHub) seems to fix it

Has anyone else run into a similar situation - we haven’t noticed this on any other sites we manage?

Stack trace:

Stash\Exception\InvalidArgumentException thrown with message "Invalid or Empty Node passed to getItem constructor."

Stacktrace:
#34 Stash\Exception\InvalidArgumentException in /home/<site>/public_html/concrete/vendor/tedivm/stash/src/Stash/Pool.php:115
#33 Stash\Pool:getItem in /home/<site>/public_html/concrete/src/Cache/Cache.php:173
#32 Concrete\Core\Cache\Cache:getItem in /home/<site>/public_html/concrete/src/Permission/Access/Access.php:188
#31 Concrete\Core\Permission\Access\Access:getAccessListItems in /home/<site>/public_html/concrete/src/Permission/Access/Access.php:124
#30 Concrete\Core\Permission\Access\Access:validateAccessEntities in /home/<site>/public_html/concrete/src/Permission/Access/Access.php:152
#29 Concrete\Core\Permission\Access\Access:validate in /home/<site>/public_html/concrete/src/Permission/Key/Key.php:568
#28 Concrete\Core\Permission\Key\Key:validate in /home/<site>/public_html/concrete/src/Permission/Response/Response.php:111
#27 call_user_func_array in /home/<site>/public_html/concrete/src/Permission/Response/Response.php:111
#26 Concrete\Core\Permission\Response\Response:validate in /home/<site>/public_html/concrete/src/Permission/Response/PageResponse.php:60
#25 Concrete\Core\Permission\Response\PageResponse:canViewPage in /home/<site>/public_html/concrete/src/Permission/Response/PageResponse.php:206
#24 Concrete\Core\Permission\Response\PageResponse:testForErrors in /home/<site>/public_html/concrete/src/Permission/Checker.php:32
#23 Concrete\Core\Permission\Checker:__construct in /home/<site>/public_html/concrete/controllers/panel/sitemap.php:46
#22 Concrete\Controller\Panel\Sitemap:view in /home/<site>/public_html/concrete/src/Controller/AbstractController.php:315
#21 call_user_func_array in /home/<site>/public_html/concrete/src/Controller/AbstractController.php:315
#20 Concrete\Core\Controller\AbstractController:runAction in /home/<site>/public_html/concrete/src/Routing/ControllerRouteAction.php:64
#19 Concrete\Core\Routing\ControllerRouteAction:execute in /home/<site>/public_html/concrete/src/Http/RouteDispatcher.php:37
#18 Concrete\Core\Http\RouteDispatcher:dispatch in /home/<site>/public_html/concrete/src/Http/Middleware/DispatcherDelegate.php:39
#17 Concrete\Core\Http\Middleware\DispatcherDelegate:next in /home/<site>/public_html/concrete/src/Http/Middleware/MiddlewareStack.php:86
#16 Concrete\Core\Http\Middleware\MiddlewareStack:process in /home/<site>/public_html/concrete/src/Http/DefaultDispatcher.php:126
#15 Concrete\Core\Http\DefaultDispatcher:handleDispatch in /home/<site>/public_html/concrete/src/Http/DefaultDispatcher.php:59
#14 Concrete\Core\Http\DefaultDispatcher:dispatch in /home/<site>/public_html/concrete/src/Http/Middleware/DispatcherDelegate.php:39
#13 Concrete\Core\Http\Middleware\DispatcherDelegate:next in /home/<site>/public_html/concrete/src/Http/Middleware/ThumbnailMiddleware.php:76
#12 Concrete\Core\Http\Middleware\ThumbnailMiddleware:process in /home/<site>/public_html/concrete/src/Http/Middleware/MiddlewareDelegate.php:50
#11 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in /home/<site>/public_html/concrete/src/Http/Middleware/FrameOptionsMiddleware.php:39
#10 Concrete\Core\Http\Middleware\FrameOptionsMiddleware:process in /home/<site>/public_html/concrete/src/Http/Middleware/MiddlewareDelegate.php:50
#9 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in /home/<site>/public_html/concrete/src/Http/Middleware/CookieMiddleware.php:35
#8 Concrete\Core\Http\Middleware\CookieMiddleware:process in /home/<site>/public_html/concrete/src/Http/Middleware/MiddlewareDelegate.php:50
#7 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in /home/<site>/public_html/concrete/src/Http/Middleware/ApplicationMiddleware.php:29
#6 Concrete\Core\Http\Middleware\ApplicationMiddleware:process in /home/<site>/public_html/concrete/src/Http/Middleware/MiddlewareDelegate.php:50
#5 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in /home/<site>/public_html/concrete/src/Http/Middleware/MiddlewareStack.php:86
#4 Concrete\Core\Http\Middleware\MiddlewareStack:process in /home/<site>/public_html/concrete/src/Http/DefaultServer.php:85
#3 Concrete\Core\Http\DefaultServer:handleRequest in /home/<site>/public_html/concrete/src/Foundation/Runtime/Run/DefaultRunner.php:128
#2 Concrete\Core\Foundation\Runtime\Run\DefaultRunner:run in /home/<site>/public_html/concrete/src/Foundation/Runtime/DefaultRuntime.php:102
#1 Concrete\Core\Foundation\Runtime\DefaultRuntime:run in /home/<site>/public_html/concrete/dispatcher.php:45
#0 require in /home/<site>/public_html/index.php:2

EvanCooper · June 29, 2023, 10:07pm

Not sure if any of these threads might help:

github.com/concretecms/concretecms

Index Search Engine - All - "Invalid or Empty Node passed to getItem constructor."

opened 05:56PM - 02 Mar 16 UTC

closed 03:35AM - 04 Sep 16 UTC

adam187

Type:Bug

When runing `Index Search Engine - All` job from `Automated Jobs` we get an erro…r ``` json { "error": true, "result": "Invalid or Empty Node passed to getItem constructor.", "jDateLastRun": "Mar 2, 2016, 6:54:30 PM", "jHandle": "index_search_all", "jID": "2", "message": "Invalid or Empty Node passed to getItem constructor." } ``` This is happening on `concrete5.7.5.6` I debug it a bit and i find out that reason for this behaviour was Page with only one version that wasn't approved. So what is happing is: Reindexing is triggered here: https://github.com/concrete5/concrete5/blob/develop/web/concrete/job... Then this code is triggered to get specific page in specific version: https://github.com/concrete5/concrete5/blob/develop/web/concrete/src... Then this function failed get page version since there is only one version and it's not approved. https://github.com/concrete5/concrete5/blob/develop/web/concrete/src... Then this code is triggered and try to get page from cache: https://github.com/concrete5/concrete5/blob/develop/web/concrete/src... But since $version variable is empty, this library throws an exception https://github.com/tedious/Stash/blob/v0.12.1/src/Stash/Pool.php#L13... because key that is trying to get cache for key `page/474//Concrete\Core\Page\Page` I don't exactly know where wrong logic lives, i'm not C5 developer, i only debugged issue. So it would be better if somebody that knows system better find solution for this edge case.