Concrete site not indexing pages that have title fields empty in blocks

Developing with Concrete
1

Concrete version 9.2.2
PHP Version 8.0.30

Hey all! Was hoping someone might be able to point me in the correct direction on this. Essentially what’s happened is, we realized that a lot of pages on our client’s site are not coming up in site search. The reason for this is because the pages are not being added to the pagesearchindex table in the database.

I’ve been able to narrow down the issue. There are a few custom blocks that we have on the site. Each of them have a title field that is labeled as optional. If they are not filled out, the titles are automatically filled by the page’s name, or other relevant info depending on the block. It seems, for some reason, if those fields are not filled out and allowed to use the defaults, site indexing skips over the entire page that they are located on.

I know this is the case because I’ve already checked to see if the attributes responsible for skipping indexing were enabled on the pages themselves or their parents, they are not. And through testing, I found that as soon as all title fields have manually typed text in them, the index grabs the page right away.

Anyone have any idea why this could be happening?

2

Do your block controllers have a getSearchableContent function? It’s possible that function is referencing something like $this->title and that’s not defined in the class. You might just need to add something like this:

/**
 * @var string|null
 */
public $title;
3

They do use getSearchableContent. Here is an example for one of the blocks.:

  public function getSearchableContent()
  {
    $page = Page::getCurrentPage();
    $pageTitle =
      isset($this->title) && is_string($this->title) && strlen($this->title) > 0
        ? $this->title
        : $page->getCollectionName();
    $content =
      isset($this->body) && strlen($this->body) > 0
        ? strip_tags($this->body)
        : "";
    return $pageTitle . " " . $content;
  }

I’ll be forward in saying that this function is something that I do not have a good understanding of. I attempted your fix by adding the recommended code to the Class Controller at the top of the controller file. But after adding it and re-attempting the index, no dice.

4

So you are referencing both $this->title and $this->body so both of those need to be explicitly defined. I am guessing this function fails with a PHP8 error and that’s why the pages don’t get indexed.

5

I think you hit the nail on the head. Defining the variables within the class isn’t fixing the issue. However if I remove the getSearchableContent function entirely, the page now gets indexed. That isn’t the fix I’m happy with, but it certainly shows that function is the issue. Thank you so much for your insight!

6

I believe I’ve found that the issue is stemming from the use of:

$page = Page::getCurrentPage();

And

$page->getCollectionName();

It seems the point in which it’s breaking is when it needs to get the collection name. Any idea as to why collection name would be un-obtainable within that function? Unfortunately I’m not seeing any php errors come up when testing this in local, so I can’t point to any error message.

7

This doesn’t answer your question, but there is really no reason to put the page name into the searchable content for this block because the page name will already be in the searchable content for the page.

8

I came to that conclusion soon after posting again, so that’s a good enough reason for me to call this done and dusted. Though I am curious as to why you cant seem to use “Page::getCurrentPage()” within that function. I eventually found out that when grabbing a page using that, inside of the getSearchableContent function, it returns as null. Which is why nothing was populating.