Help with isEditMode

Developing with Concrete
1

I have the following code in my HTML:

<nav class="navbar navbar-default top-bar affix" data-spy="affix" data-offset-top="250" >

    <? if ($c->isEditMode()) { ?>
      <div style="height: 50px">&nbsp;</div>
    <? } ?>

      <div class="container">

When in edit mode I do get the style applied and everything is fine and works as expected.

When I exit edit mode, the style is still applied and I get this displayed in the upper left of the browser:
isEditMode()) { ?>

If I remove the php code to apply the style, the page is all good, except when in edit mode, I can’t get to the sticky menu.

Really don’t want to mess with the css unless we have to. We actually got this snippet from one of Andrew’s legacy videos (Theme Development P4) and have used it in the past.

I’m missing something really simple ain’t I?

2

Try using

<?php

instead of

<?
3

Oops, should have mentioned that I did try <?php, sorry about that…

4

@mlocati has given you the correct answer, your code should be

<?php if ($c->isEditMode()) { ?>
 <div style="height: 50px">&nbsp;</div>
<?php } ?>
5

Thanks for all the help. But I am really at a loss (not the first time), but this is a new one to me.

I’ve tried everything I know including all your suggestions with the most recent post by ConcreteOwl.

Here is the strange thing. In my HTML I have this:

<!-- trying Posted C5 Fix-->
<?php echo "<h1>Not Editing</h1>"; ?> // THIS DISPLAYs in Either Case!!!
<?php if ($c->isEditMode()) { ?> //THIS CODE DOES NOT SEEM TO BE EXECUTING!
<div style="height: 50px">&nbsp;</div>
<?php echo "<h1>AM Editing</h1>"; ?>
<?php } ?>
<!-- End -->

Pretty straight forward. If not Logged in display NOT editing, if logged in display AM editing…

I’ve attached several snapshots showing in Edit Mode and Non-Edit Mode

Voyage-NotLLoggedIn
Voyage-NotLLoggedIn1344×252 19.3 KB

Voyage-LoggedIn
Voyage-LoggedIn1254×230 20.6 KB

Voyage-Either Way_Source

Basic relevant HTML:

<!------------Static navbar ------------>
<nav class="navbar navbar-default top-bar affix" data-spy="affix" data-offset-top="250" >

<!-- trying Posted C5 Fix-->
<?php if ($c->isEditMode()) { ?>
 <div style="height: 50px">&nbsp;</div>
<?php } ?>
<!-- End -->

      <div class="container">

short_open_tag=On, but it doesn’t seem to matter.

I am at a loss as to what is not taking place and/or why.

Everyone that has contributed - thanks, but this is just weird. Happens with Chrome, Edge and even Safari on iMac…

Sorry all, this is on a Local Dev Server and is NOT front facing. If I need to post a different way, please let me know.

6

Your original post appears to have some php comments wrapping the code.
php comments instruct the browser to not execute the php instruction between the comments and display them as normal text.

7

A screenshot of your code would be useful as well

8

OMG and Embarrassed!!! I wasted a bunch of everyone’s time.

I did not realize that there is a caveat to isEditMode. Apparently, one needs to actually begin the Edit process (i.e. edit the page - Pencil/Add Content). I assumed that when one was logged in, you are in edit mode!!!

After revisiting Andrew’s video, I did not realize that he was already in EDIT mode in the backend, so when he posted the code it worked fine. But had he not of been in edit mode it would not have worked much like mine. Viewer oversight.

So I believe my final resolution is this (mostly from all the suggestions and a quick google) - if anyone sees a hole here please let me know):

<?php
    $u = new User();
    if($u->isLoggedIn()) { ?>
      <div style="height: 50px">&nbsp;</div>
   <? }
?>

May not be the best solution, but it certainly does represent the original HTML template almost to the pixel and in edit mode all is well and fine.

I don’t think it’s a total loss from my perspective (not withstanding everyone’s time/effort) and that being said the other posts/suggestion will come in handy in the future I’m sure.

Learning new things are harder than knowing old things.

Truly, thanks everyone.

Hope everyone has a great Holiday Season - cheers.

1 Like
9

If you wanted to restrict this to the admin of the site, you could use

<?php $u = new User(); if($u->isSuperUser()) { ?>
  <div style="height: 50px">&nbsp;</div>
<?php } ?>
10

The offset for the Concrete toolbar when logged in is usually 48px. Most themes use a top margin to apply this offset to div.ccm-page

You can do it with css only. The class ccm-toolbar-visible is applied to the < html> element.

In actual edit mode, the class ccm-edit-mode is also applied.

11

The video that you refer to is some 12 years old now and concretecms has evolved a lot since then.
The php language has also evolved a lot and the latest offering from php.net is version 8.x, this is much more strict than the php version of 12 years ago, I would recommend that using php short tags should be avoided if possible.
Glad you got it sorted now and I know the members on this forum are only too happy to help.