Straw poll - addon + theme compatibility with v9

mesuva · October 18, 2021, 9:04am

To handle tabs, what I did was do a check for anything under v9, to work out if a prefix to the class is needed:

Mesuva/list_files_from_set/blob/master/blocks/list_files_from_set/edit.php#L16

    
      
          $al = $app->make('helper/concrete/asset_library');
          ?>
          
          
<?php
          echo $app->make('helper/concrete/ui')->tabs(array(
              array('fileset', t('Select File Set'), true),
              array('display', t('Display Options'))));
          
          
$prefix = '';
          
          
$version = $app->make('config')->get('concrete.version');
          if (version_compare($version, '9.0', '<')) {
              $prefix = 'ccm-tab-content-';
          }
          
          
?>
          
          
<div class="tab-content">
          
          
    <div class="ccm-tab-content tab-pane active" id="<?= $prefix; ?>fileset">
                  <fieldset>

and then add the prefix on each tab-pane:

github.com

Mesuva/list_files_from_set/blob/master/blocks/list_files_from_set/edit.php#L25

    
      
          
          
$version = $app->make('config')->get('concrete.version');
          if (version_compare($version, '9.0', '<')) {
              $prefix = 'ccm-tab-content-';
          }
          
          
?>
          
          
<div class="tab-content">
          
          
    <div class="ccm-tab-content tab-pane active" id="<?= $prefix; ?>fileset">
                  <fieldset>
                      <?php
                      $filesets = FileSet::getMySets();
                      $fsID = $controller->getFileSetID();
                      ?>
                      <div class="form-group">
          
          
                <label class="control-label mb-2" for="numberFiles"><?php echo t('Display'); ?>
                              <?php echo $form->text('numberFiles', $numberFiles, array('maxlength'=>'10', 'style'=>'display: inline; width: 70px')); ?>
                              <?php echo t('files from:'); ?>