Version 9.4.3 Express Form error

@mlocati @frz
I have been trying to add an express form to a page in version 9.4.3
I installed an empty instance of 9.4.3 to ensure that the errors were not being generated by a theme or other block/addon.
When selecting the express form block an error was being thrown preventing the form dialog from displaying.
I tracked this down to a bug introduced in the 9.4.3 release…
The controller file in concrete/blocks/express_form/controller.php has this code on line 984

protected function getFormEntity()
    {
        $entityManager = $this->app->make(EntityManagerInterface::class);

        return $entityManager->find(Form::class, $this->exFormID);
    }

Replacing this function with this fixes the error

protected function getFormEntity()
    {
        $entityManager = $this->app->make(EntityManagerInterface::class);
        return $entityManager->getRepository(\Concrete\Core\Entity\Express\Form::class)
            ->findOneById($this->exFormID);
    }

This replacement function was copied from the controller file in version 9.4.2

1 Like

@mlocati has already worked out a fix for this.

1 Like